denispolandDevin
463f29e76a
`void resp.body?.cancel()` in streamChatEvents' finally floated a rejected promise: an aborted fetch errors the body with the abort reason, and cancel() on an errored stream rejects with it, escaping as unhandledRejection -> uncaughtException and killing pi on Escape. Await the cancel inside the existing try/catch so the rejection is actually swallowed. Adds a regression test that aborts a mocked in-flight stream and asserts no unhandled rejection is raised. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
70 lines
2.4 KiB
JavaScript
70 lines
2.4 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
import { normalizeContext } from "@earendil-works/pi-ai";
|
|
import { clearCachedUserJwt } from "../src/jwt.ts";
|
|
import { streamDevin } from "../src/stream.ts";
|
|
import { encodeMessage } from "../src/wire.ts";
|
|
|
|
const model = {
|
|
id: "test-model",
|
|
name: "Test model",
|
|
api: "devin-local",
|
|
provider: "devin",
|
|
baseUrl: "https://devin.invalid",
|
|
reasoning: false,
|
|
input: ["text", "image"],
|
|
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
|
|
contextWindow: 262_000,
|
|
maxTokens: 1_000,
|
|
};
|
|
const user = (content) => ({ role: "user", content, timestamp: 1 });
|
|
|
|
test("aborting an in-flight stream reports aborted without leaking a rejection", async (t) => {
|
|
clearCachedUserJwt();
|
|
t.after(clearCachedUserJwt);
|
|
|
|
const rejections = [];
|
|
const onRejection = (reason) => rejections.push(reason);
|
|
process.on("unhandledRejection", onRejection);
|
|
t.after(() => process.off("unhandledRejection", onRejection));
|
|
|
|
const ac = new AbortController();
|
|
t.mock.method(globalThis, "fetch", async (url, options) => {
|
|
if (url === "https://devin.invalid/exa.auth_pb.AuthService/GetUserJwt") {
|
|
return new Response(encodeMessage(1, Buffer.from("eyJtest.jwt")));
|
|
}
|
|
assert.equal(url, "https://devin.invalid/exa.api_server_pb.ApiServerService/GetChatMessage");
|
|
// Mirror undici: an aborted fetch errors the response body with signal.reason.
|
|
const body = new ReadableStream({
|
|
start(controller) {
|
|
controller.enqueue(new TextEncoder().encode("partial"));
|
|
const onAbort = () => controller.error(options.signal.reason);
|
|
if (options.signal?.aborted) onAbort();
|
|
else options.signal?.addEventListener("abort", onAbort, { once: true });
|
|
},
|
|
});
|
|
return new Response(body);
|
|
});
|
|
|
|
const stream = streamDevin(model, normalizeContext({ messages: [user("hello")] }), {
|
|
apiKey: "synthetic-test-key",
|
|
env: { DEVIN_API_SERVER_URL: "https://devin.invalid" },
|
|
signal: ac.signal,
|
|
});
|
|
|
|
const events = [];
|
|
const consume = (async () => {
|
|
for await (const event of stream) events.push(event);
|
|
})();
|
|
ac.abort();
|
|
await consume;
|
|
// Give any floating rejection a chance to surface.
|
|
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
|
|
const last = events.at(-1);
|
|
assert.equal(last?.type, "error");
|
|
assert.equal(last?.reason, "aborted");
|
|
assert.equal((await stream.result()).stopReason, "aborted");
|
|
assert.deepEqual(rejections, []);
|
|
});
|